aaron/ispc
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Fix linkage for programIndex et al. when not debugging.

Browse Source 
We now use InternalLinkage for the 'programIndex' symbol (and similar)
if we're not compiling with debugging symbols.  This prevents those
symbol names/definitions from polluting the global namespace for
the common case.

Basically addresses Issue #274.
This commit is contained in:
Matt Pharr
2012-06-15 11:50:16 -07:00
parent a23a7006e3
commit 4b334fd2e2
1 changed files with 7 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
builtins.cpp
View File

@@ -646,8 +646,9 @@ lDefineConstantInt(const char *name, int val, llvm::Module *module,
// Use WeakODRLinkage rather than InternalLinkage so that a definition
// survives even if it's not used in the module, so that the symbol is
// there in the debugger.
sym->storagePtr = new llvm::GlobalVariable(*module, ltype, true,
llvm::GlobalValue::WeakODRLinkage,
llvm::GlobalValue::LinkageTypes linkage = g->generateDebuggingSymbols ?
llvm::GlobalValue::WeakODRLinkage : llvm::GlobalValue::InternalLinkage;
sym->storagePtr = new llvm::GlobalVariable(*module, ltype, true, linkage,
linit, name);
symbolTable->AddVariable(sym);
@@ -704,10 +705,10 @@ lDefineProgramIndex(llvm::Module *module, SymbolTable *symbolTable) {
llvm::Type *ltype = LLVMTypes::Int32VectorType;
llvm::Constant *linit = LLVMInt32Vector(pi);
// See comment in lDefineConstantInt() for why WeakODRLinkage is used here
sym->storagePtr = new llvm::GlobalVariable(*module, ltype, true,
llvm::GlobalValue::WeakODRLinkage,
linit,
sym->name.c_str());
llvm::GlobalValue::LinkageTypes linkage = g->generateDebuggingSymbols ?
llvm::GlobalValue::WeakODRLinkage : llvm::GlobalValue::InternalLinkage;
sym->storagePtr = new llvm::GlobalVariable(*module, ltype, true, linkage,
linit, sym->name.c_str());
symbolTable->AddVariable(sym);
if (m->diBuilder != NULL) {