aaron/ispc
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Pretty much all conversions to varying double are slow, so don't bother warning about them.

Browse Source
This commit is contained in:
Matt Pharr
2011-09-23 16:03:35 -07:00
parent d261105a86
commit fade1cdf1d
1 changed files with 1 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
expr.cpp
View File

@@ -4114,7 +4114,7 @@ lTypeConvAtomic(FunctionEmitContext *ctx, llvm::Value *exprVal,
case AtomicType::TYPE_BOOL: case AtomicType::TYPE_BOOL:
if (fromType->IsVaryingType() && if (fromType->IsVaryingType() &&
LLVMTypes::BoolVectorType == LLVMTypes::Int32VectorType) LLVMTypes::BoolVectorType == LLVMTypes::Int32VectorType)
// If we have a bool vector of i32 element,s first truncate // If we have a bool vector of i32 elements, first truncate
// down to a single bit // down to a single bit
exprVal = ctx->TruncInst(exprVal, LLVMTypes::Int1VectorType, "bool_to_i1"); exprVal = ctx->TruncInst(exprVal, LLVMTypes::Int1VectorType, "bool_to_i1");
// And then do an unisgned int->float cast // And then do an unisgned int->float cast
@@ -4174,9 +4174,6 @@ lTypeConvAtomic(FunctionEmitContext *ctx, llvm::Value *exprVal,
case AtomicType::TYPE_UINT16: case AtomicType::TYPE_UINT16:
case AtomicType::TYPE_UINT32: case AtomicType::TYPE_UINT32:
case AtomicType::TYPE_UINT64: case AtomicType::TYPE_UINT64:
if (fromType->IsVaryingType())
PerformanceWarning(pos, "Conversion from unsigned int64 to float is slow. "
"Use \"int64\" if possible");
cast = ctx->CastInst(llvm::Instruction::UIToFP, // unsigned int cast = ctx->CastInst(llvm::Instruction::UIToFP, // unsigned int
exprVal, targetType, "uint2double"); exprVal, targetType, "uint2double");
break; break;