small comment changes, remove dead code

This commit is contained in:
Matt Pharr
2011-06-22 14:38:49 -07:00
parent bf74a3360f
commit 2ced56736e
2 changed files with 1 additions and 7 deletions

View File

@@ -3203,6 +3203,7 @@ ConstExpr::ConstExpr(ConstExpr *old, double *v)
break; break;
case AtomicType::TYPE_INT64: case AtomicType::TYPE_INT64:
case AtomicType::TYPE_UINT64: case AtomicType::TYPE_UINT64:
// For now, this should never be reached
FATAL("fixme; we need another constructor so that we're not trying to pass " FATAL("fixme; we need another constructor so that we're not trying to pass "
"double values to init an int64 type..."); "double values to init an int64 type...");
default: default:

View File

@@ -665,19 +665,12 @@ lEmitFunctionCode(FunctionEmitContext *ctx, llvm::Function *function,
lCopyInTaskParameter(i, structParamPtr, decl, ctx); lCopyInTaskParameter(i, structParamPtr, decl, ctx);
// Copy in the mask as well. // Copy in the mask as well.
// FIXME: we may probably to check the mask at runtime and emit an
// 'all on' code path if it is all on, since that should be a
// common case.
#if 1
int nArgs = decl->functionArgs ? decl->functionArgs->size() : 0; int nArgs = decl->functionArgs ? decl->functionArgs->size() : 0;
// The mask is the last parameter in the argument structure // The mask is the last parameter in the argument structure
llvm::Value *ptr = ctx->GetElementPtrInst(structParamPtr, 0, nArgs, llvm::Value *ptr = ctx->GetElementPtrInst(structParamPtr, 0, nArgs,
"task_struct_mask"); "task_struct_mask");
llvm::Value *ptrval = ctx->LoadInst(ptr, NULL, "mask"); llvm::Value *ptrval = ctx->LoadInst(ptr, NULL, "mask");
ctx->SetEntryMask(ptrval); ctx->SetEntryMask(ptrval);
#else
Warning(funSym->pos, "Running task with all-on mask to start.");
#endif
// Copy threadIndex and threadCount into stack-allocated storage so // Copy threadIndex and threadCount into stack-allocated storage so
// that their symbols point to something reasonable. // that their symbols point to something reasonable.